[Bug 428435] Review Request: shezhu - Shezhu Resource Sharing System

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: shezhu - Shezhu Resource Sharing System


https://bugzilla.redhat.com/show_bug.cgi?id=428435





------- Additional Comments From leamas at bredband.net  2008-01-11 13:45 EST -------
This is not a review, just a rookie skimming  through the spec file...

Style: CAPITAL letters in Summary: and Description looks odd.
%files: You should probably use %{_var} instead of /var
%files: /usr/lib should probably be %{_libdir}, taking possible 64-bit 
issues into account.
but then also the Makefile must do the Right Thing.
%files: Use %{_sbindir} instead of /usr/sbin IMHO.
Is it important that the file(s) installed under /usr/sbin is owned by
apache/apache? Don't know if/where this is regulated, but normally executables
are owned by root. Since you seem to install with default 755 permission, I
don't get the point... OTOH, I'm used to that feeling ;-)

BTW. this also introduces a dependency on the 'apache' user... How is that handled?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.