[Bug 428586] Review Request: ldm - LTSP Display Manager

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ldm - LTSP Display Manager


https://bugzilla.redhat.com/show_bug.cgi?id=428586


a.badger at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |a.badger at gmail.com
             Status|NEW                         |ASSIGNED




------- Additional Comments From a.badger at gmail.com  2008-01-15 07:54 EST -------
Good:
* spec matches the base package.
* License is GPLv2+
* License is included with package.
* Spec is coherent American English
* Package builds and installs on i386
* Not a library

Needswork:
* Is this a pre-release snapshot?  If so the release should be 0.1.20080114.
  [Fix attached]
* Source needs to have instructions for retrieving from upstream (since it's a
  snapshot)
  [Fix attached]
* Not all BuildRequires are listed: Needs gtk2-devel, does not need libtool
  [Fix attached]
* Needs to own %{_datadir}/ldm
  [Fix attached]
* rpmlint output::
    ldm.i386: E: non-executable-script /usr/share/ldm/ldm-script 0644
  This looks like a script that is intended to start and stop services when
  a user logs into the box.  Does it need to be executable?
  [Not fixed]

Notes:
* When upstream releases a tarball of this package it will likely be named ldm2
  (judging from the tarball that make dist creates).  Since the main binary is
  named ldm and we're not likely to package ldm1 ever, I think naming this
  package ldm is fine.
* No locales are currently installed but there are some translations available.
  When those are installed, be sure to include them using %{find_lang} so that
  they are properly marked as language files.
* Although this is a graphical application, it does not need a .desktop file
  because it does not run from a desktop session.  Instead it is used to
  start a desktop session.

I'll attach a new spec file in a moment that addresses most of the issues.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.