[Bug 428549] Review Request: trac-monotone-plugin - Monotone version control plugin for Trac

bugzilla at redhat.com bugzilla at redhat.com
Wed Jan 16 03:49:37 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: trac-monotone-plugin - Monotone version control plugin for Trac


https://bugzilla.redhat.com/show_bug.cgi?id=428549





------- Additional Comments From geoff at programmer-monk.net  2008-01-15 22:49 EST -------
(In reply to comment #3)
> Interesting that this build for Geoff, because it doesn't build for me.  Geoff,
> did you do a mock build?  Against which version of Fedora did you build?

I thought it was clear from my comment but I guess not.  It did not build for me
in mock, but it did build outside of mock since I already had trac installed.  I
probably should have pasted the failure from mock.  All part of the learning
experience.

> Wow, this is significantly broken; you can't even use setup.py to create the
> tarball without having trac installed.  Really suboptimal.

It seems that they import the main module in setup.py so they only have to
specify the version number in one place.  I can see why this is attractive but I
would think there is a less irritating way to do it.

> I did the checkout as instructed in the spec and the content I get differs.  I
> think it's important to specify a date or a tag or whatever monotone supports to
> ensure that we can get a consistent checkout in the absense of an actual release
> tarball.

I really don't understand why upstream doesn't seem to have tagged any
revisions, bizarre.

> On the plus side, it looks like many of the shebang lines are gone in the
> checkout I made.

Well that's one good thing I suppose.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the Fedora-package-review mailing list