[Bug 428793] Review Request: xhtml2fo-style-xsl - Antenna House, Inc. XHTML to XSL:FO stylesheets

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xhtml2fo-style-xsl - Antenna House, Inc. XHTML to XSL:FO stylesheets


https://bugzilla.redhat.com/show_bug.cgi?id=428793





------- Additional Comments From ovasik at redhat.com  2008-01-16 15:30 EST -------
Few things I see without rpmlint check: 
1) License should be rpmlint valid, from xsl files I think correct one could be
License: Freely redistributable without restriction
2) Because of /usr/bin/xmlcatalog usage in post and postun you have to add
Requires: libxml2 (maybe only Requires(post):libxml2 , Requires(postun):libxml2) 
3) Build root has to follow packaging guidelines (for example could be 
   BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
4) PreReq: are obsolete, should be changed to Requires:
5) One small suggestion is to drop version and release from directory - it will
cleanup the directory structure and is safe - removal from catalog is done only
when removing package. Modified %postun will look like:
%postun
# remove entries only on removal of package
if [ "$1" = 0 ]; then
  CATALOG=%{_sysconfdir}/xml/catalog
  %{_bindir}/xmlcatalog --noout --del \
  "file://%{_datadir}/sgml/docbook/xhtml2fo-stylesheets/xhtml2fo.xsl" $CATALOG
fi

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.