[Bug 428793] Review Request: xhtml2fo-style-xsl - Antenna House, Inc. XHTML to XSL:FO stylesheets

bugzilla at redhat.com bugzilla at redhat.com
Thu Jan 17 19:08:08 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xhtml2fo-style-xsl - Antenna House, Inc. XHTML to XSL:FO stylesheets


https://bugzilla.redhat.com/show_bug.cgi?id=428793





------- Additional Comments From ismael at olea.org  2008-01-17 14:08 EST -------
(In reply to comment #4)
> Few things I see without rpmlint check: 
> 1) License should be rpmlint valid, from xsl files I think correct one could be

Ok, I've used an old rpmlint

> 2) Because of /usr/bin/xmlcatalog usage in post and postun you have to add
> Requires: libxml2 (maybe only Requires(post):libxml2 , Requires(postun):libxml2) 

I understand, but seems rpmlint doesn't agree :-)

[olea at lisergia 2008]$ rpmlint -iv
/usr/src/redhat/RPMS/noarch/xhtml2fo-style-xsl-20051222-1.noarch.rpm
xhtml2fo-style-xsl.noarch: I: checking

xhtml2fo-style-xsl.noarch: E: explicit-lib-dependency libxml2
You must let rpm find the library dependencies by itself. Do not put unneeded
explicit Requires: tags.

xhtml2fo-style-xsl.noarch: E: explicit-lib-dependency libxml2
You must let rpm find the library dependencies by itself. Do not put unneeded
explicit Requires: tags.

> 3) Build root has to follow packaging guidelines (for example could be 
>    BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

Ok

> 4) PreReq: are obsolete, should be changed to Requires:

Ok

> 5) One small suggestion is to drop version and release from directory - it will
> cleanup the directory structure and is safe - removal from catalog is done only
> when removing package. 

I don't have preference. Probably I've only copied the style from
docbook-xsl-stylesheets.spec

> Modified %postun will look like:
> %postun
> # remove entries only on removal of package
> if [ "$1" = 0 ]; then
>   CATALOG=%{_sysconfdir}/xml/catalog
>   %{_bindir}/xmlcatalog --noout --del \
>   "file://%{_datadir}/sgml/docbook/xhtml2fo-stylesheets/xhtml2fo.xsl" $CATALOG
> fi

I not understand how exactly the $1 variable works there, but if you are sure, I
don't have the problem for changing it.

Revised versions:
Spec URL: http://olea.org/tmp/xhtml2fo-style-xsl.spec
SRPM URL: http://olea.org/paquetes-rpm/xhtml2fo-style-xsl-20051222-1.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the Fedora-package-review mailing list