[Bug 191492] Review Request: unuran-0.7.2

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: unuran-0.7.2


https://bugzilla.redhat.com/show_bug.cgi?id=191492


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |tibbs at math.uh.edu
               Flag|                            |fedora-review?




------- Additional Comments From tibbs at math.uh.edu  2008-01-18 18:49 EST -------
This one build fine.  Perhaps you're not building in mock; the dir file is
probably probably only created in specific circumstances you'd see on a clean
system.

So, to recap the rpmlint complaints:

  unuran.src: W: mixed-use-of-spaces-and-tabs (spaces: line 26, tab: line 1)
Not a big deal; fix it if you like.

  unuran-devel.x86_64: W: hidden-file-or-dir 
   /usr/share/doc/unuran-devel-1.1.0/examples/.deps
  unuran-devel.x86_64: W: hidden-file-or-dir 
   /usr/share/doc/unuran-devel-1.1.0/examples/.deps
I don't think this really needs to be packaged at all; it's just makedep output
and all of the files there contain nothing but the string "# dummy".  Unless you
can point to something that doesn't work without it, of course.

There's a rather extensive test suite included here, which I think should be
run.  It does take quite some time but I don't expect that this will be built
all that often, and it might turn up issues on the platforms on which most of us
can't easily test.  Just add this after the %install section:
  %check
  make check
However, doing this turns up a problem: the tests actually fail for me (sorry
for wrapping; the test suite output isn't very readable):

distr_condi: [new  ==> ok] [set  ==> ok] [get  ==> ok] [chg  ==> ok] [init  ==>
ok] [reinit  ==> ok] [sample  ==> ok] [validate
(verify hat)  condi_standardmultinormal_3++++++++++
condi_standardmultinormal_4+++++ condi_multinormal_random(!+)++++
condi_standardmultinormal_domain+++++++++.+++++ ==> failed]
FAIL: t_distr_condi

gibbs: [new  ==> ok] [set  ==> ok] [get  ==> ok] [chg  ==> ok] [init  ==> ok]
[reinit  ==> ok] [sample  ==> ok] [validate
(chi^2)  multinormal+++++++++++++++?(!+)++++
multinormal_ar1++++++..++..++..++..++..++..++++
multinormal_constantrho++..++..++++++.. multicauchy00++00++00++
multicauchy_ar100?++00++00++00?+?(!+) multistudent_ar100++00++00++00++00++00++
multinormal+.+.+.+.+.+.0000 ==> failed]
FAIL: t_gibbs

hinv: [new  ==> ok] [set  ==> ok] [get  ==> ok] [chg  ==> ok] [init  ==> ok]
[reinit  ==> ok] [sample  ==> ok] [validate
mock.Root.build: (chi^2) 
beta+++++++++++++++++++++.+++++++++++++++++.++++++++++++++++++++++++++++++++++++++++++++++++++
cauchy++++++++++++++++++ exponential++++++++++++++++++
gamma+++++++++++++++++++++++++++++++++++++++.+++.++++.++++++++.+++.++++.+++.+++++++++++++++++.+
laplace++++++++++++++++.+ normal++++++++++++.+++.++++++++++
uniform++++++++++++.+++-+ F++++++++++++++++++++++++++++++++++++++(!+)+(!+)++++
cauchy+++++++.. beta++++++++. unknown++++++.+.+++++.++.
triangular-string+++...... triangular-invalid-string000......000...... ==>
failed] [special
test maximal
u-error++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
test unur_chg_truncated():  normal++++++++++++++++++++++++++++++++++++++++
sinus1++++++++++++++++++++++++++++++++++++++++
sinus2++++++++++++++++++++++++++++++++++++++++ ==> ok]
FAIL: t_hinv

===============================================
3 of 54 tests failed
Please report to unuran at statistik.wu-wien.ac.at
===============================================

Perhaps you could investigate these with upstream.  Maybe there's some x86_64 issue?


* source files match upstream:
   a297f28a717b8ddd50bf06fb98301b780ed4e2246dfa5427b02dbf6d40caa879  
   unuran-1.1.0.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper (none)
* compiler flags are appropriate.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly
* debuginfo package looks complete.
X rpmlint has a valid complaint.
* final provides and requires are sane:
  unuran-1.1.0-5.fc9.x86_64.rpm
   libunuran.so.7()(64bit)
   unuran = 1.1.0-5.fc9
  =
   /bin/sh
   /sbin/install-info
   /sbin/ldconfig
   libunuran.so.7()(64bit)

  unuran-devel-1.1.0-5.fc9.x86_64.rpm
   unuran-devel = 1.1.0-5.fc9
  =
   libunuran.so.7()(64bit)
   unuran = 1.1.0-5.fc9

X %check is not present, but there seems to be a test suite.  When added, the 
   test suite fails.
* shared libraries present; ldconfig is called as necessary and unversioned .so 
   files are in the -devel package.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* scriptlets look OK (ldconfig and info files)
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* headers are in the -devel package.
* no pkgconfig files.
* no static libraries.
* no libtool .la files.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.