[Bug 252257] Review Request: perl-MogileFS-Server - Server part of the MogileFS distributed filesystem
bugzilla at redhat.com
bugzilla at redhat.com
Sat Jan 19 07:51:02 UTC 2008
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: perl-MogileFS-Server - Server part of the MogileFS distributed filesystem
https://bugzilla.redhat.com/show_bug.cgi?id=252257
tibbs at math.uh.edu changed:
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|nobody at fedoraproject.org |tibbs at math.uh.edu
Status|NEW |ASSIGNED
Flag| |fedora-review?
------- Additional Comments From tibbs at math.uh.edu 2008-01-19 02:51 EST -------
Not sure why I never looked at this one. Unfortunately it fails to build for
me, because the mogstored-shutdown test fails:
Failed Test Stat Wstat Total Fail Failed List of Failed
-------------------------------------------------------------------------------
t/mogstored-shutdown.t 255 65280 4 5 125.00% 2-4
The output from the failing test is:
(No info could be read for "-p": geteuid()=7225 but you should be root.)
(Not all processes could be identified, non-owned process info
will not be shown, you would have to be root to see it all.)
real_pid = 24068
# Failed test 'got mgmt connection'
# in t/mogstored-shutdown.t at line 41.
IO::Socket::INET: connect: Connection refused ...propagated at t/mogstored-shutdown.t line 41.
No clue what's going on here; mock builds don't run as root so I doubt this
test is going to work properly. I'd suggest just deleting
t/mogstored-shutdown in %check, unless you think you can patch it to do
something useful.
I went ahead and deleted that test so I could look at the rest of the package.
rpmlint says:
mogstored-backend-apache.noarch: W: no-documentation
mogstored-backend-lighttpd.noarch: W: no-documentation
mogstored-backend-perlbal.noarch: W: no-documentation
which are all OK.
I note that mogilefsd includes a license note:
"Same terms as Perl itself. Artistic/GPLv2, at your choosing."
This is a bit confusing, because the two statements are not the same. I'm
going to have to assume that the second statement is merely a confused
explanation and that the first actually states the reality, but as usual you
should actually talk to them and ask them what they intend.
I'm a bit confused about the name of this package; I'm thinking that it would
make more sense to just call the SPRM "mogilefsd" or "mogilefs-server".
There's certainly no reason to name it with the mixed case since even on CPAN
it's named in lower case.
Should the perlbal backend have some sort of dependency on perlbal? It
doesn't seem to have one currently.
Checklist:
* source files match upstream:
05ce0dcd8973dee68f9cf28e9111fa639a62eaea8836099717381de237ff0aee
mogilefs-server-2.17.tar.gz
? I'm unsure about the proper name of this package.
* specfile is properly named, is cleanly written and uses macros consistently.
* summaries are OK.
* descriptions are OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
X package fails to build in mock unless I remove one of the tests.
* package installs properly
* rpmlint has acceptable complaints.
? final provides and requires are sane:
mogilefsd-2.17-2.fc9.noarch.rpm
config(mogilefsd) = 2.17-2.fc9
perl(Mgd)
perl(MogileFS)
perl(MogileFS::Class)
perl(MogileFS::Config)
perl(MogileFS::Connection::Client)
perl(MogileFS::Connection::Mogstored)
perl(MogileFS::Connection::Worker)
perl(MogileFS::DevFID)
perl(MogileFS::Device)
perl(MogileFS::DeviceState)
perl(MogileFS::Domain)
perl(MogileFS::Exception)
perl(MogileFS::FID)
perl(MogileFS::HTTPFile)
perl(MogileFS::Host)
perl(MogileFS::IOStatWatch::Client)
perl(MogileFS::IOStatWatcher)
perl(MogileFS::ProcManager)
perl(MogileFS::RebalancePolicy)
perl(MogileFS::RebalancePolicy::DrainDevices)
perl(MogileFS::RebalancePolicy::PercentFree)
perl(MogileFS::RebalancePolicy::Random)
perl(MogileFS::ReplicationPolicy)
perl(MogileFS::ReplicationPolicy::MultipleHosts)
perl(MogileFS::ReplicationRequest)
perl(MogileFS::Server) = 2.17
perl(MogileFS::Store)
perl(MogileFS::Store::MySQL)
perl(MogileFS::Sys)
perl(MogileFS::Util)
perl(MogileFS::Worker)
perl(MogileFS::Worker::Delete)
perl(MogileFS::Worker::Fsck)
perl(MogileFS::Worker::Monitor)
perl(MogileFS::Worker::Query)
perl(MogileFS::Worker::Reaper)
perl(MogileFS::Worker::Replicate)
mogilefsd = 2.17-2.fc9
=
/bin/bash
/bin/sh
/sbin/chkconfig
/sbin/service
/usr/bin/perl
config(mogilefsd) = 2.17-2.fc9
initscripts
perl(Carp)
perl(DBD::mysql)
perl(DBI)
perl(DBI) >= 1.44
perl(Danga::Socket)
perl(Danga::Socket) >= 1.56
perl(Exporter)
perl(File::Basename)
perl(File::Copy)
perl(File::Path)
perl(Getopt::Long)
perl(IO::Socket)
perl(IO::Socket::INET)
perl(LWP::UserAgent)
perl(List::Util)
perl(MogileFS::Class)
perl(MogileFS::Config)
perl(MogileFS::Connection::Client)
perl(MogileFS::Connection::Mogstored)
perl(MogileFS::Connection::Worker)
perl(MogileFS::DevFID)
perl(MogileFS::Device)
perl(MogileFS::DeviceState)
perl(MogileFS::Domain)
perl(MogileFS::Exception)
perl(MogileFS::FID)
perl(MogileFS::HTTPFile)
perl(MogileFS::Host)
perl(MogileFS::IOStatWatcher)
perl(MogileFS::ProcManager)
perl(MogileFS::RebalancePolicy::DrainDevices)
perl(MogileFS::ReplicationPolicy::MultipleHosts)
perl(MogileFS::ReplicationRequest)
perl(MogileFS::Server)
perl(MogileFS::Store)
perl(MogileFS::Store::MySQL)
perl(MogileFS::Sys)
perl(MogileFS::Util)
perl(MogileFS::Worker::Delete)
perl(MogileFS::Worker::Fsck)
perl(MogileFS::Worker::Monitor)
perl(MogileFS::Worker::Query)
perl(MogileFS::Worker::Reaper)
perl(MogileFS::Worker::Replicate)
perl(Net::Netmask)
perl(POSIX)
perl(Socket)
perl(Symbol)
perl(Sys::Hostname)
perl(Sys::Syscall) >= 0.22
perl(Sys::Syslog)
perl(Time::HiRes)
perl(base)
perl(constant)
perl(fields)
perl(lib)
perl(overload)
perl(strict)
perl(vars)
perl(warnings)
shadow-utils
mogstored-2.17-2.fc9.noarch.rpm
perl(Mogstored::ChildProcess)
perl(Mogstored::ChildProcess::DiskUsage)
perl(Mogstored::ChildProcess::FIDSizes)
perl(Mogstored::ChildProcess::IOStat)
perl(Mogstored::FIDStatter)
perl(Mogstored::HTTPServer)
perl(Mogstored::SideChannelClient)
perl(Mogstored::SideChannelListener)
mogstored = 2.17-2.fc9
=
/bin/bash
/bin/sh
/sbin/chkconfig
/sbin/service
/usr/bin/perl
initscripts
perl(Carp)
perl(Errno)
perl(FindBin)
perl(Gearman::Client) >= 1.06
perl(Gearman::Client::Async) >= 0.93
perl(Gearman::Server) >= 1.08
perl(Gearman::Worker)
perl(Getopt::Long)
perl(IO::Socket::INET)
perl(Mogstored::HTTPServer)
perl(Mogstored::SideChannelClient)
perl(Mogstored::SideChannelListener)
perl(POSIX)
perl(Perlbal) >= 1.53
perl(Storable)
perl(base)
perl(fields)
perl(lib)
perl(strict)
perl(warnings)
shadow-utils
mogstored-backend-apache-2.17-2.fc9.noarch.rpm
perl(Mogstored::HTTPServer::Apache)
mogstored-backend-apache = 2.17-2.fc9
=
httpd
perl(File::Temp)
perl(Mogstored::HTTPServer)
perl(base)
perl(strict)
mogstored-backend-lighttpd-2.17-2.fc9.noarch.rpm
perl(Mogstored::HTTPServer::Lighttpd)
mogstored-backend-lighttpd = 2.17-2.fc9
=
lighttpd
perl(File::Temp)
perl(Mogstored::HTTPServer)
perl(base)
perl(strict)
? mogstored-backend-perlbal-2.17-2.fc9.noarch.rpm
perl(Mogstored::HTTPServer::Perlbal)
mogstored-backend-perlbal = 2.17-2.fc9
=
perl(Fcntl)
perl(Mogstored::HTTPServer)
perl(POSIX)
perl(base)
perl(strict)
X %check is present but fails; if I remove one test, I get:
All tests successful, 6 tests skipped.
Files=9, Tests=25, 1 wallclock secs ( 1.05 cusr + 0.21 csys = 1.26 CPU)
The skipped tests require a running mysql server and a configuration to
access it.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* scriptlets look OK (user/group addition, initscripts)
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
More information about the Fedora-package-review
mailing list