[Bug 428603] Review Request: Falcon - The Falcon Programming Language

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Falcon - The Falcon Programming Language


https://bugzilla.redhat.com/show_bug.cgi?id=428603





------- Additional Comments From michel.sylvan at gmail.com  2008-01-19 18:07 EST -------
Created an attachment (id=292278)
 --> (https://bugzilla.redhat.com/attachment.cgi?id=292278&action=view)
Changes to latest Falcon spec file

Several things:
- the XXXXXX in the call to mktemp lets you do multiple builds of the same
package at the same time, by generating a randomized 6-digit number; keep it

- One more use of /usr; I substituted %{_prefix} for it
- %{buildroot} is actually fine; to use that or $RPM_BUILD_ROOT is just
  a matter of style
- First attempt at a fixed file listing. 
- Your package builds fine on x86_64, but there is currently no way to override

  the location of library files (on x86_64 and ppc64, Fedora expects the
  libraries to be in /usr/lib64, which is what %{_libdir} expands to). Fix
  build.sh to allow the library path to be passed as argument?
- Also make it possible to override CFLAGS and CXXFLAGS with the content of
  $RPM_OPT_FLAGS
- (this one is optional) While you're at it, would be nice if the -p directive
  to set where the package is to be installed can be passed only at install
  time, rather than at boot time (similar to how most Makefiles asks you for
the
  PREFIX (your final prefix) first, and the DESTDIR is only needed when
  installing)
- falcon-conf -L reports the wrong library path: it reports the value of -p
  instead of -f
- Do you really Requires: gcc at runtime? If anything it should be gcc-c++.
  If you mean BuildRequires:, gcc and gcc-c++ are standard build requirements
  that do not have to be explicitly listed

Feel free to rearrange the files between the main package and -devel. The idea
is that files needed by people who program in Falcon goes in -devel and files
needed to run pre-existing Falcon scripts in the main package.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.