[Bug 429444] Review Request: libmspack - A library for compression and decomepression

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libmspack - A library for compression and decomepression


https://bugzilla.redhat.com/show_bug.cgi?id=429444





------- Additional Comments From pertusus at free.fr  2008-01-20 07:00 EST -------
To fix the rpmlint warning on the debuginfo package, you can do
chmod a-x mspack/mspack.h
in %prep or %build or even %install (I prefer %prep).

Why is there a BR on convmv?

I think that the version release should better be
Version: 0.0
Release: 0.1.20060920alpha%{?dist}

To keep the ChangeLog timestamp you can do
iconv -f ISO_8859-1 -t utf8 ChangeLog --output Changelog.utf8
touch -r ChangeLog Changelog.utf8
mv Changelog.utf8 ChangeLog

I suggest using for the summary something more specific like
Summary:        Library for CAB and related files compression and decompression


The doc file could also be installed in %doc of the -doc
package.

If you still prefer to install them in the directory looking like
the main package directory, I think it would be better to 
install them in a directory with the release too. Also instead of
the find for the install which also installs unneeded files, I 
propose:

install -p -m 0644 doc/*.html doc/*.gif doc/*.png doc/*.css \
   $RPM_BUILD_ROOT%{_docdir}/%{name}/

Another suggestion, is to use 
rm $RPM_BUILD_ROOT%{_libdir}/libmspack.la
instead of 
find $RPM_BUILD_ROOT -name '*.la' -exec rm -f {} ';'

Also I suggest not having the -doc package depend on the other
packages, docs are interesting even if the other packages aren't 
installed.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.