[Bug 427718] Review Request: Megazeux - Text-character driven game creation system

bugzilla at redhat.com bugzilla at redhat.com
Fri Jan 25 14:55:26 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Megazeux - Text-character driven game creation system


https://bugzilla.redhat.com/show_bug.cgi?id=427718





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2008-01-25 09:55 EST -------
* Please consider to use disttag.
  http://fedoraproject.org/wiki/Packaging/DistTag* Rebuild failed.

* Rebuild failed
  http://koji.fedoraproject.org/koji/taskinfo?taskID=372587
  - It seems that at least libpng-devel is missing from BuildRequires.
  - build.log says:
----------------------------------------------------------------
X11 could not be queried, disabling.
----------------------------------------------------------------
    Does this mean that some X releated development pacakges are
    required for BuildRequires?

* BuildRoot tag does not meet Fedora guidelines yet.
  Please check the section "BuildRoot tag" of
  http://fedoraproject.org/wiki/Packaging/Guidelines

* Please make build log more verbose. The output like
-----------------------------------------------------------------
+ make -j8
  CC       contrib/gdm2s3m/src/error.c
  CC       contrib/gdm2s3m/src/gdm.c
  CC       contrib/gdm2s3m/src/s3m.c
------------------------------------------------------------------
  is not useful and we cannot check if fedora specific compilation
  flags are correctly honored.

* ChangeLog entry should be like:
------------------------------------------------------------------
* Thu Jan 24 2008 Steve Salevan <ssalevan at redhat.com> 281h-2
------------------------------------------------------------------

! Please increase the release number of your spec file when
  you modify your spec file to avoid confusion.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the Fedora-package-review mailing list