[Bug 430377] Review Request: atop - An advanced interactive monitor to view the load on system and process level

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: atop - An advanced interactive monitor to view the load on system and process level


https://bugzilla.redhat.com/show_bug.cgi?id=430377





------- Additional Comments From wolfy at nobugconsulting.ro  2008-01-27 04:20 EST -------
The package has an excellent start, but there are a few things that must be fixed
- according to the soruces, the correct license tag is GPLv2+
- in the init.d script, please replace _all_ references to ntpd with atop
- in your %build section, make does not activate parallel compiling 
- the default Makefile enforces some specific compiler flags, ignoring the
mandatory Fedora ones.
Using
   make %{?_smp_mflags} CFLAGS="$RPM_OPT_FLAGS"
solves both the above issues
- your %pre/%post scriptlets make use of chkconfig and service. Therefore your
Requires section must contain (see
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#head-97754e2c646616c5f6222f0cfc6923c60765133e
for details):
Requires(post): /sbin/chkconfig
Requires(preun): /sbin/chkconfig
Requires(preun): /sbin/service
- the name of the logrotate file is quite odd ("dummy..."). May I suggest to 
settle on a more meaningful one ?
- %description contains the following line "** package don't has resources the
patch:" 
It is neither correct English ( English grammar recommends "package doesn't have
<whatever else is in the phrase>) nor does it have a sense (the last noun is in
no way correlated to the first part of the sentence). As a non-native English
speaker, frankly I have absolutely no idea of what you want to communicate here
(OK, I lie, I have looked at upstream's site and I do have an idea). Could you
please rephrase the whole sentence (for instance "The package does not make use
of the patches available at http://www.atcomputing.nl/Tools/atop/kernpatch.html"
, if this is what you meant to say) ?


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.