[Bug 430578] Review Request: xmlcopyeditor - A fast, free, validating XML editor

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xmlcopyeditor - A fast, free, validating XML editor


https://bugzilla.redhat.com/show_bug.cgi?id=430578





------- Additional Comments From marc at mwiriadi.id.au  2008-01-28 18:20 EST -------
rpmlint: [marc at Strike-Lap i386]$ rpmlint xmlcopyeditor-*
xmlcopyeditor.i386: W: no-documentation
xmlcopyeditor.i386: W: no-version-in-last-changelog
xmlcopyeditor.i386: W: file-not-in-%lang /usr/share/xmlcopyeditor/po/de/messages.mo
xmlcopyeditor.i386: W: file-not-in-%lang /usr/share/xmlcopyeditor/po/fr/messages.mo
xmlcopyeditor.i386: W: file-not-in-%lang /usr/share/xmlcopyeditor/po/sk/messages.mo
xmlcopyeditor.i386: W: file-not-in-%lang /usr/share/xmlcopyeditor/po/sv/messages.mo
xmlcopyeditor.i386: W: file-not-in-%lang
/usr/share/xmlcopyeditor/po/zh_CN/messages.mo
xmlcopyeditor.i386: W: file-not-in-%lang
/usr/share/xmlcopyeditor/po/zh_TW/messages.mo
xmlcopyeditor-debuginfo.i386: W: spurious-executable-perm
/usr/src/debug/xmlcopyeditor-1.1.0.6/src/pathresolver.h
xmlcopyeditor-debuginfo.i386: W: spurious-executable-perm
/usr/src/debug/xmlcopyeditor-1.1.0.6/src/mypropertysheet.h
xmlcopyeditor-debuginfo.i386: W: spurious-executable-perm
/usr/src/debug/xmlcopyeditor-1.1.0.6/src/xsllocator.h
xmlcopyeditor-debuginfo.i386: W: spurious-executable-perm
/usr/src/debug/xmlcopyeditor-1.1.0.6/src/housestylereader.h
xmlcopyeditor-debuginfo.i386: W: spurious-executable-perm
/usr/src/debug/xmlcopyeditor-1.1.0.6/src/readfile.cpp
xmlcopyeditor-debuginfo.i386: W: spurious-executable-perm 
xmlcopyeditor-debuginfo.i386: W: no-version-in-last-changelog

Lots of rpmlint errors in your package. 

Please add documentation there are some files there with information which
should be included in the %doc section.  

Add this in the files section for the %lang: %files -f %{name}.lang
Add this in the install section for the %lang: %find_lang %{name}
Remove the Requires unless you plan on using it
Lots of permission issues in the debug package please fix those.
Thats it for the moment.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.