[Bug 429084] Review Request: vamp-plugin-sdk - An API for audio analysis and feature extraction plugins

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: vamp-plugin-sdk - An API for audio analysis and feature extraction plugins


https://bugzilla.redhat.com/show_bug.cgi?id=429084


panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From panemade at gmail.com  2008-01-29 00:15 EST -------
Review:
+ package builds in mock (rawhide i386).
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
aeda086f10227e6ca473f714ac025807  vamp-plugin-sdk-1.1b.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ BuildRequires are proper.
+ Compiler flags used correctly.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ static libraries present in -static subpackage.
+ .pc files present.
+ -devel and -static subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ ldconfig scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Package vamp-plugin-sdk-1.1b-3.fc9 ->
  Provides: libvamp-hostsdk.so.2.0.0 libvamp-sdk.so.1.1.0
  Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3)
libc.so.6(GLIBC_2.4) libgcc_s.so.1 libgcc_s.so.1(GCC_3.0) libm.so.6
libm.so.6(GLIBC_2.0) libstdc++.so.6 libstdc++.so.6(CXXABI_1.3)
libstdc++.so.6(GLIBCXX_3.4) libvamp-hostsdk.so.2.0.0 libvamp-sdk.so.1.1.0
rtld(GNU_HASH)
+ Package vamp-plugin-sdk-devel-1.1b-3.fc9 ->
  Requires: libvamp-hostsdk.so.2.0.0 libvamp-sdk.so.1.1.0 pkgconfig
vamp-plugin-sdk = 1.1b-3.fc9
+ Package vamp-plugin-sdk-static-1.1b-3.fc9 ->
  Requires: vamp-plugin-sdk-devel = 1.1b-3.fc9
+ Not a GUI App.
APPROVED.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.