[Bug 448337] Review Request: enlightenment - a next generation desktop shell

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: enlightenment - a next generation desktop shell


https://bugzilla.redhat.com/show_bug.cgi?id=448337


mtasaka at ioa.s.u-tokyo.ac.jp changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtasaka at ioa.s.u-tokyo.ac.jp




------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2008-07-02 13:56 EST -------
For 0.16.999.043-1:

! Question
  - Would you explain what .edj files are? Can this be freely
    (re)distributable?

* Multiple issues on -devel subpackage
  ** Requires
     - efeet-devel is also needed for Requires of -devel subpackage
       (see e.h)

  ** pkgconfig file
--------------------------------------------------------------
$ pkg-config --libs enlightenment
/usr/lib/enlightenment/modules  
--------------------------------------------------------------
     - This is perhaps wrong (pkg-config --libs foo should usually
       return -Ldir -lfoo -baa .....)

  ** "config.h" inclusion
     - From %_includedir/%name/e.h:
--------------------------------------------------------------
     4  #ifndef E_H
     5  #define E_H
     6  
     7  #include "config.h"
     8  
--------------------------------------------------------------
       but 1. config.h is not installed and 2. config.h must not be
       needed for installed header files.

* %prep
  - Perhaps the following is simpler:
---------------------------------------------------------------
%setup -q
# strip out bundled vera font, it doesn't support national glyphs
rm -r data/fonts
sed -i \
	-e '\|CONFIG_FILES="\$CONFIG_FILES data/fonts/Makefile"|d' \
	-e 's|data/fonts/Makefile||' \
	configure ; chmod +x configure
sed -i -e 's|fonts||' data/Makefile.in
sed -i -e '\|\.ttf|d' data/{init,themes}/default.edc
---------------------------------------------------------------

* Duplicate files
  - Please check if the following files are really needed.
    They are also installed as %doc.
---------------------------------------------------------------
/usr/share/enlightenment/AUTHORS
/usr/share/enlightenment/COPYING
---------------------------------------------------------------

* Directory ownership issue
  - Please make it sure that all directories created when installing
    this package are correctly owned by this package.
    Example:
---------------------------------------------------------------
[tasaka1 at localhost ~]$ rpm -qf /usr/lib/enlightenment/preload/e_precache.so 
enlightenment-0.16.999.043-1.fc10.i386
[tasaka1 at localhost ~]$ rpm -qf /usr/lib/enlightenment/preload/              
file /usr/lib/enlightenment/preload is not owned by any package
[tasaka1 at localhost ~]$ rpm -qf /usr/lib/enlightenment/        
file /usr/lib/enlightenment is not owned by any package
---------------------------------------------------------------

* setuid files
  - Please explain why two binaries must have setuid bits.
    Also please consider if pam mechanism or so can replace this.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.