[Bug 452872] Review Request: bmake - The NetBSD make(1) tool

bugzilla at redhat.com bugzilla at redhat.com
Thu Jul 3 06:40:32 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: bmake - The NetBSD make(1) tool


https://bugzilla.redhat.com/show_bug.cgi?id=452872


mtasaka at ioa.s.u-tokyo.ac.jp changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2008-07-03 02:40 EST -------
* Without "BuildRequires: mk-files", your srpm on comment 5 does not build.
  Please add this.
* Perhaps Requires: mk-files *">= 20070430"* is redundant.

Other things are okay.
! Note: Usually to keep timestamps on installed files, when using "install" or
        "cp" commands, "-p" option must be added. However for this package
        all files (except for %doc files) are modified during build and "-p"
        option does not make sense.

-----------------------------------------------------------------------------
              This package (bmake) is APPROVED by me
-----------------------------------------------------------------------------

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the Fedora-package-review mailing list