[Bug 226363] Merge Review: redhat-lsb

bugzilla at redhat.com bugzilla at redhat.com
Thu Jul 3 08:28:59 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: redhat-lsb


https://bugzilla.redhat.com/show_bug.cgi?id=226363





------- Additional Comments From petersen at redhat.com  2008-07-03 04:28 EST -------
-License: GPL
+License: GPLv2

You are sure it is GPLv2 and not GPLv2+?

-Requires: /usr/lib/lsb/install_initd
-Requires: /usr/lib/lsb/remove_initd
+Requires: %{_libdir}/lsb/install_initd
+Requires: %{_libdir}/lsb/remove_initd

Why is redhat-lsb requiring it's own files?

-         $RPM_BUILD_ROOT/%{_bindir} $RPM_BUILD_ROOT/usr/lib/lsb \
+         $RPM_BUILD_ROOT/%{_bindir} $RPM_BUILD_ROOT%{_libdir}/lsb \
:
-ln -snf ../../../sbin/chkconfig $RPM_BUILD_ROOT/usr/lib/lsb/install_initd
-ln -snf ../../../sbin/chkconfig $RPM_BUILD_ROOT/usr/lib/lsb/remove_initd
+ln -snf ../../../sbin/chkconfig $RPM_BUILD_ROOT%{_libdir}/lsb/install_initd
+ln -snf ../../../sbin/chkconfig $RPM_BUILD_ROOT%{_libdir}/lsb/remove_initd
:
-/usr/lib/lsb
-/lib/lsb
+%{_libdir}/lsb
+/%{_lib}/lsb

I don't think /usr/lib/lsb and /lib/lsb should be changed to
%{_libdir}/lsb and %{_lib}/lsb.  I guess they are intentional.


 * Fri Jan 21 2005 Leon Ho <llch at redhat.com> 1.3-7
 - Add to support multiple LSB test suite version
-- Add %endif in trigger postun
+- Add endif in trigger postun

Good

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the Fedora-package-review mailing list