[Bug 442329] Review Request: gnome-lirc-properties - Infrared Remote Controls setup tool

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gnome-lirc-properties - Infrared Remote Controls setup tool


https://bugzilla.redhat.com/show_bug.cgi?id=442329





------- Additional Comments From dan at danny.cz  2008-07-03 10:40 EST -------
formal review:

OK	source files match upstream:
	    240068639dec59409f29b1b1ba881db557fcace8  gnome-lirc-properties-0.2.8.tar.gz
OK	package meets naming and versioning guidelines.
OK	specfile is properly named, is cleanly written and uses macros consistently.
OK	dist tag is present.
OK	build root is correct.
OK	license field matches the actual license.
OK	license is open source-compatible (GPLv2+). License text included in package.
OK	latest version is being packaged.
OK	BuildRequires are proper.
N/A	compiler flags are appropriate.
OK	%clean is present.
OK	package builds in mock (Rawhide/x86_64).
N/A	debuginfo package looks complete.
BAD	rpmlint is silent.
OK	final provides and requires look sane.
N/A	%check is present and all tests pass.
OK	no shared libraries are added to the regular linker search paths.
BAD	owns the directories it creates.
OK	doesn't own any directories it shouldn't.
OK	no duplicates in %files.
OK	file permissions are appropriate.
BAD	scriptlets present.
OK	code, not content.
OK	documentation is small, so no -docs subpackage is necessary.
OK	%docs are not necessary for the proper functioning of the package.
OK	no headers.
OK	no pkgconfig files.
OK	no libtool .la droppings.
BAD	is a GUI app.


bugs
* %{_sysconfdir}/dbus-1/system.d/*.conf must be marked as %config
* use %{_datadir}/omf/gnome-lirc-properties (the whole directory) in %files
* desktop file not installed or validated
(https://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files + some
discussion on fedora-{devel,packaging} regarding the use of
desktop-file-validate), calling desktop-file-validate should be sufficient in
this case
* the scriptlets need minor updates to fully comform the
https://fedoraproject.org/wiki/Packaging/ScriptletSnippets

additional notes
* occurrences of the string "g-l-p" could be replaced by %{name}, but this is
only my opinion
* call to autoconf can be replaced with autoreconf


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.