[Bug 454078] Review Request: khmeros-fonts - Khmer free/libre font set created by Danh Hong of the Cambodian Open Institute

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: khmeros-fonts - Khmer free/libre font set created by Danh Hong of the Cambodian Open Institute


https://bugzilla.redhat.com/show_bug.cgi?id=454078





------- Additional Comments From nicolas.mailhot at laposte.net  2008-07-04 16:52 EST -------
Proposed spec changes:
1. re-word description a little
2. macroify version in archivename
3. kill the external non-upstream-provided license file
(even if you kept it it's not necessary to install it this way, %doc takes care
of a lot of things)

--- khmeros-fonts.spec	2008-07-04 15:40:50.000000000 +0200
+++ khmeros-fonts-nim.spec	2008-07-04 22:49:39.000000000 +0200
@@ -1,27 +1,26 @@
 %define fontname        khmeros
 %define fontdir         %{_datadir}/fonts/%{fontname}
-%define archivename     All_KhmerOS_5.0
+%define archivename     All_KhmerOS_%{version}
 
 Name:           %{fontname}-fonts
 Version:        5.0
 Release:        1%{?dist}
-Summary:        Khmer free/libre font set created by Danh Hong of the Cambodian
Open Institute
+Summary:        Khmer font set created by Danh Hong of the Cambodian Open Institute
 
 Group:          User Interface/X
 License:        LGPLv2+
 URL:            http://www.khmeros.info/drupal/?q=en/download/fonts
 Source0:        http://downloads.sourceforge.net/khmer/%{archivename}.zip
-Source1:        COPYRIGHT.Fedora
 BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 
 BuildArch:      noarch
 
 %description
-All font include Khmer and Latin alphabets, and they have equivalent sizes 
-for Khmer and English alphabets, so that when texts mix both it is not 
-necessary to have different size points of the text for each language. 
-This makes localization possible. Khmer OS System is our system font. It 
-is hinted, so that it can be used and clearly understood in small sizes.
+The Khmer OS fonts include Khmer and Latin alphabets, and they have equivalent
+sizes for Khmer and English alphabets, so that when texts mix both it is not 
+necessary to have different point sizes for the text in each language.
+
+They were created by Danh Hong of the Cambodian Open Institute.
 
 
 %prep
@@ -36,8 +35,6 @@
 
 install -dm 755 %{buildroot}%{fontdir}
 install -pm 644 *.ttf %{buildroot}%{fontdir}
-install -dm 755 %{buildroot}%{_datadir}/doc/%{name}
-install -pm 644 %{SOURCE1} %{buildroot}%{_datadir}/doc/%{name}
 
 
 %clean
@@ -59,7 +56,6 @@
 %defattr(644,root,root,755)
 %dir %{fontdir}/
 %{fontdir}/*.ttf
-%doc %{_datadir}/doc/%{name}/COPYRIGHT.Fedora
 
 
 %changelog


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.