[Bug 252108] Review Request: python-html5lib - A python based HTML5 parser/tokenizer

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-html5lib - A python based HTML5 parser/tokenizer


https://bugzilla.redhat.com/show_bug.cgi?id=252108





------- Additional Comments From rakesh.pandit at gmail.com  2008-07-05 06:38 EST -------
I am not sponsored. So my review is just to help this package go through 
process:

You can drop the %if 0%{?fedora} >= 8, conditional stuff is no longer needed as 
new releases wouldn't trigger it -- verify from reviewer or on #fedora-devel

You should remove tests/ folder.

[X] rpmlint output:
python-html5lib.src: W: uncompressed-zip /html5lib-0.10.zip
The zip file is not compressed.
   -- ignored Check
[X] md5sum  -- matches Check
[X] version guideline naming convention -- Check
[X] spec file name -- Check
[X] description and summary -- Check
[X] build root -- Check
[X] spec license field and compatibility  -- Checked
[X] license file -- absent in source -- Check
[X] readable and American language -- Check
[X] %clean -- present -- Check
[X] compile and build using koji -- Check
[X] rpmlint is silent except one message above -- Check
[X] %docs not required, no headers, no static libraries

Optional:
you may query upstream about including license text as a separate file.

Package looks okay to me.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.