[Bug 434861] Review Request: python-tftpy - Python TFTP library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-tftpy - Python TFTP library


https://bugzilla.redhat.com/show_bug.cgi?id=434861


rakesh.pandit at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rakesh.pandit at gmail.com




------- Additional Comments From rakesh.pandit at gmail.com  2008-07-05 11:42 EST -------
I am not sponsored yet. So, cannot officially review your package. But to help 
here is an:

Unofficial package review
===============
rpmlint -i <srpm>:
python-tftpy.src: W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line 4)
python-tftpy.src: E: description-line-too-long Tftpy is a TFTP library for the 
Python programming language. It includes client and server classes, with sample 
implementations. Hooks are included for
python-tftpy.src: E: description-line-too-long easy inclusion in a UI for 
populating progress indicators. It supports RFCs 1350, 2347 and 2348.

rpmlint -i <rpm>
python-tftpy.noarch: W: spurious-executable-perm /usr/share/doc/python-
tftpy-0.4.5/bin/tftpy_server.py
python-tftpy.noarch: W: doc-file-dependency /usr/share/doc/python-tftpy-0.4.5/
bin/tftpy_server.py /usr/bin/env


- You seem to have mixed tabs and spaces
- Try wrapping description to 80 columns (1 column = 1 char) a line
- bin files -- 'bin/tftpy_client.py' & 'bin/tftpy_server.py' should go to 'doc' 
but they should go to 'bin'
 you are excluding .pyc and .pyo but files are not there.  
- you need to replace env in these files with %{__python} -- may be consult 
reviewer
 
Required 
=====
[x] Package naming & spec file naming 
[x] md5sum matches for source from srpm and project page
[?] License field present, but file COPYING does not look license to me -- 
     It says 'if you press accept' so essentially it is being used  while using 
this program. 
     It looks okay to me - but may be do some more research.
[x] spec file is legible and written in American English
[x] All files are in utf-8 
[x] no static libraries, no libtool, package does not own files or folders used 
by other packages.
[x] nothing used in %doc for runtime.
[x] consistently used macros
[x] package build and compile using koji 
[-] tabs and spaces mixed 
[-] dependency env warning
[-] description is okay but needs to be wrapped.

Optional 
=====
[x] latest stable packaged 
[?] includes a COPYING file but needs some more research
  
-N/A, x = check, ! = Problem and ? = Not evaluated 

It is okay, just needs some quick fixs in my few.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.