[Bug 428435] Review Request: shezhu - Shezhu Resource Sharing System

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: shezhu - Shezhu Resource Sharing System


https://bugzilla.redhat.com/show_bug.cgi?id=428435





------- Additional Comments From wolfy at nobugconsulting.ro  2008-07-06 10:25 EST -------
Tim, are you still interested in this bug? 'Cause if you do, there are a couple
of fixes needed. Most important one being the fact that
- you claim the package is noarch but
- in %files you use %{_libdir}/shezhu which leads to the following error:
Checking for unpackaged file(s): /usr/lib/rpm/check-files
/var/tmp/shezhu-1.20-1.fc10-OFXMjR
error: Installed (but unpackaged) file(s) found:
   /usr/lib/shezhu/Makefile
   /usr/lib/shezhu/README.loc
   /usr/lib/shezhu/access.loc
   /usr/lib/shezhu/action.js
[...] (very long list of unpackaged stuff here)

On a different line, I am not sure how important is this fragment from the end
of the build process:
TXT="MIDI" BOX=48x14 STR=23x8 ASC=8 DES=0 LFT=12 TOP=3 OUT=base-images/MIDI.gif
TXT="MINI" BOX=48x14 STR=23x8 ASC=8 DES=0 LFT=12 TOP=3 OUT=base-images/MINI.gif
TXT="LCDP" BOX=48x14 STR=29x8 ASC=8 DES=0 LFT=9 TOP=3 OUT=base-images/LCDP.gif
Error: string width bigger than bounding box, 84 > -3
(I usually tend to avoid "error"s)

In terms of the spec file
- you should also use add "-q" to setup, in order to silence it 
- remove one of the two occurences of "perl" in the BR line.
- what's the significance of the following lines under %description:
Generic (Build 2008.02.01.12.24)
Supports dates from 01/02/2008 to 31/01/2009 and expires on 01/02/2009
- last but not least, the web page of the project claims that Image::Magick
would be needed, but the spec does not require / use it.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.