[Bug 452749] Review Request: ocp - Open Cubic Player for MOD/S3M/XM/IT/SID/MIDI music files

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ocp - Open Cubic Player for MOD/S3M/XM/IT/SID/MIDI music files


https://bugzilla.redhat.com/show_bug.cgi?id=452749





------- Additional Comments From rpm at greysector.net  2008-07-07 13:40 EST -------
Full review (relevant issues only)

$ rpmlint /var/lib/mock//fedora-development-i386/result
ocp.src: W: mixed-use-of-spaces-and-tabs (spaces: line 61, tab: line 61)
3 packages and 0 specfiles checked; 0 errors, 1 warnings.

Looks fine, that warning can be ignored.

Packaging Guidelines:

I'd rather you installed the icons as
/usr/share/icons/hicolor/{16x16,48x48}/apps/ocp.xpm
and used
Icon=ocp
in the desktop file instead of the full path. Or is the path /usr/share/pixmaps
hardcoded somewhere? This will of course require adding the proper gtk icon
cache update calls to %post(un).

Licencing is a bit problematic. Most files have just copyright assignment and no
licence header at all. Some have no licencing information whatsoever. Just
putting a COPYING file with GPL text in it in the tarball doesn't cut it. Please
work with upstream to fix that.

Source matches upstream:
b936f236b41e7f1184e401f5e099debe  ocp-0.1.15.tar.bz2

Builds fine on i386/devel and x86_64/F-8.

Everything else seems fine.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.