[Bug 454959] Review Request: eclipse-cusp - Eclipse Common Lisp Development Tools (Cusp) plugin

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: eclipse-cusp - Eclipse Common Lisp Development Tools (Cusp) plugin


https://bugzilla.redhat.com/show_bug.cgi?id=454959





------- Additional Comments From green at redhat.com  2008-07-11 08:53 EST -------
(In reply to comment #1)
> Hi Anthony.  Here are some initial comments:
> 
> - remove eclipse_lib_base and eclipse_arch
> - you've got two different Requires: eclipse-platform lines

Ok.

> - what's with the "upstream CDT ..." comment?

There's a lot of junk like that left over from the eclipse-photron spec file
from which this was derived.  I'm going to start trimming stuff out.

> - why is there something going to %{eclipse_base}/plugins/META-INF?  That
> shouldn't be.

I'm not putting anything in there, but I created the directory by mistake.  I
only needed the plugins directory.

> - what's with the wacky namespace (jasko.tim)?  Is jasko a top-level domain?

I don't know.  It's what upstream uses.

> - is this an arch-specific plugin?

It depends on sbcl, which is currently not built for ppc due to a bug.

> You  followed the Eclipse plugin packaging guidelines, right?

I didn't know they existed!  I'll look for them.

Thanks


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.