[Bug 436330] Review Request: libtrash - Libraries to move files to a trash-folder on delete

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libtrash - Libraries to move files to a trash-folder on delete


https://bugzilla.redhat.com/show_bug.cgi?id=436330





------- Additional Comments From ianweller at gmail.com  2008-07-11 12:36 EST -------
+: good, -: fail, x: doesn't apply

+ source files match upstream:
    [ianweller at slartibartfast REVIEW]$ md5sum libtrash-3.2.tgz srpm/libtrash-3.2.tgz
    56f7b54f50d760e4719f73b98cd8b43a  libtrash-3.2.tgz
    56f7b54f50d760e4719f73b98cd8b43a  srpm/libtrash-3.2.tgz
+ package meets naming and versioning guidelines.
+ specfile is properly named, is cleanly written and uses macros consistently.
+ dist tag is present.
+ build root is correct.
+ license field matches the actual license.
+ license is open source-compatible.
+ license text included in package.
+ latest version is being packaged.
+ BuildRequires are proper.
+ compiler flags are appropriate.
+ %clean is present. 
+ package builds in mock.
    dist-f8, dist-f9, and dist-f10 tested on Koji
+ package installs properly.
+ debuginfo package looks complete.
+ rpmlint is silent. 
    4 packages and 1 specfiles checked; 0 errors, 0 warnings.
+ final provides and requires are sane:
+ no shared libraries are added to the regular linker search paths.
+ owns the directories it creates.
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
- file permissions are appropriate.
    I'm not sure why the permissions on /etc/libtrash.conf are 444, everything
    else in that directory seems to be 644. Fix that.
+ no scriptlets present. 
+ code, not content.
+ documentation is small, so no -docs subpackage is necessary.
+ %docs are not necessary for the proper functioning of the package.
+ no headers.
+ no pkgconfig files.
+ no libtool .la droppings.

One remaining problem.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.