[Bug 455071] Review Request: xfce4-mpc-plugin - MPD client for the Xfce panel

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xfce4-mpc-plugin - MPD client for the Xfce panel


https://bugzilla.redhat.com/show_bug.cgi?id=455071





------- Additional Comments From kevin at tummy.com  2008-07-13 00:07 EST -------

OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
See below - License (BSD)
See below - License field in spec matches
See below - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
b4f7f67589f34f77973a51dd5069712d  xfce4-mpc-plugin-0.3.3.tar.gz
b4f7f67589f34f77973a51dd5069712d  xfce4-mpc-plugin-0.3.3.tar.gz.orig
OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package has correct buildroot
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.
OK - Package has rm -rf RPM_BUILD_ROOT at top of %install

OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
OK - No rpmlint output.
OK - final provides and requires are sane:

SHOULD Items:

OK - Should build in mock.
OK - Should build on all supported archs
OK - Should have sane scriptlets.
OK - Should have dist tag
OK - Should package latest version

Issues:

1. Is the License tag here really BSD?
I think it should be "ISC"
http://www.isc.org/index.pl?/sw/dhcp/dhcp-copyright.php
(well, it's ISC style)



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.