[Bug 454960] Review Request: aubio - An audio labelling library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: aubio - An audio labelling library


https://bugzilla.redhat.com/show_bug.cgi?id=454960


j.w.r.degoede at hhs.nl changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |j.w.r.degoede at hhs.nl
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review?




------- Additional Comments From j.w.r.degoede at hhs.nl  2008-07-13 03:55 EST -------
Initial review done, needs some work:

* License: GPL, GPL is not a valid license tag, it should be "GPLv2+"
* Gives the following errors when doing a local build:
RPM build errors:
    Installed (but unpackaged) file(s) found:
   /usr/lib/python2.5/site-packages/aubio/__init__.py
   /usr/lib/python2.5/site-packages/aubio/__init__.pyc
   /usr/lib/python2.5/site-packages/aubio/__init__.pyo
   /usr/lib/python2.5/site-packages/aubio/_aubiowrapper.so
   /usr/lib/python2.5/site-packages/aubio/aubioclass.py
   /usr/lib/python2.5/site-packages/aubio/aubioclass.pyc
   /usr/lib/python2.5/site-packages/aubio/aubioclass.pyo
   <snip>

  It looks like aubio comes with python bindings, it would probably be best to
  add the necessary BR's and put the python stuff in a sub-package.

* rpmlint says:
  aubio.src: W: mixed-use-of-spaces-and-tabs (spaces: line 31, tab: line 1)
  aubio.x86_64: E: zero-length /usr/share/doc/aubio-0.3.2/NEWS
  aubio.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/libaubioext.so.2.1.1
['/usr/lib64']
  aubio.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/aubiotrack ['/usr/lib64']
  aubio.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/aubioonset ['/usr/lib64']
  aubio.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/aubionotes ['/usr/lib64']
  aubio.x86_64: E: binary-or-shlib-defines-rpath /usr/lib/python2.5/site-packages/

  You can fix this by putting the following 3 lines between %configure and make:
# Don't use rpath!
sed -i 's|^hardcode_libdir_flag_spec=.*|hardcode_libdir_flag_spec=""|g' libtool
sed -i 's|^runpath_var=LD_RUN_PATH|runpath_var=DIE_RPATH_DIE|g' libtool


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.