[Bug 430429] Review Request: python-storm - An object-relational mapper (ORM) for Python

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-storm - An object-relational mapper (ORM) for Python


https://bugzilla.redhat.com/show_bug.cgi?id=430429





------- Additional Comments From dtimms at iinet.net.au  2008-07-14 21:48 EST -------
OK, thanks for the update, the changes take into account my previous concerns.

(In reply to comment #9)
> Unit tests are now run
...
Ran 0 tests in 0.000s

OK
(tests=0, failures=0, errors=0)

Running doctests...
[tests/tutorial.txt]
(tests=124, failures=0, errors=0)

Total test cases: 1809
Total doctests: 124
Total failures: 0
Total errors: 0
...
I can see that the unit tests are now run, and succeed. The following questions
are more for my own learning, rather than highlighting any particular issue:
- Is it normal for the unit test outputs to be echoed ?
- In the fedora build system, does that mean the unit test results will appear
in the build.log ?
- If a test fails, does that stop the build process automatically {ie at the end
of the unit tests}, so that a test failing means the package build wont complete ?
- Or does a packager have to manually check the build.log to confirm %check
succeeded ?

> The last thing is the exclusion of files -- it achieves the same result as
> using rm, and is safer as you can't accidentally clobber files outside the
> buildroot.
That's a good tip {that should be in PackagingGuidelines ?}.

* new: When it's in the repo proper, it seems that yum install python-storm
would also install one of the backends, to satisfy Requires: python-storm-backend

I guess yum will choose either the alphabetically lowest or highest of the 
3 backends, apparently randomly ? I think this would be normal for rpm packages
though, wouldn't it ?

* new: tutorial.txt - do you think it should be placed with docs {although it is
easy to find if user goes to the package's url} ?

* I ran through the tutorial itself, and found only one issue: the last part of
the tutorial - Debugging
   1 >>> import sys
   2 >>> from storm.tracer import debug

This gives me:
>>> import sys
>>> from storm.tracer import debug
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ImportError: No module named tracer

I searched for debug and tracer in the storm source, and it doesn't get
mentioned. Perhaps this is a separate source, incomplete upstream, or did the
packaging miss something ?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.