[Bug 452388] Review Request: python-migrate - Schema migration tools for SQLAlchemy

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-migrate - Schema migration tools for SQLAlchemy


https://bugzilla.redhat.com/show_bug.cgi?id=452388


lmacken at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|tibbs at math.uh.edu           |lmacken at redhat.com
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From lmacken at redhat.com  2008-07-16 16:23 EST -------
With regard to the naming issue, I'm also in favor of s/migrate/sqlalchemy-migrate/.

? rpmlint complaint: python-migrate.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/migrate/versioning/templates/manage.py_tmpl 0644
* Package name is OK, and I'd be fine with the s/migrate/sqlalchemy-migrate/
rename as well.
* Package meets the packaging guidelines
* License is valid and meets guidelines
* Specfile is clean
* Source file matches upstream
* Package successfully builds in mock
* Requires and BuildRequires are correct
* Package owns everything it creates
* Does not contain duplicate files
* Permissions are set properly
* %clean section exists
* consistent use of macros
* code, not content
* small amounts of documentation, no subpackage
* %docs do not effect runtime
* buildroot is wiped before installation
* filenames are all valid utf-8

I don't see the rpmlint "error" as an issue, since it is a template that turns
into a script once installed.

So, the rename is up to you guys -- whether we want python-migrate or
python-sqlalchemy-migrate (I tend to lean towards the latter).  Other than that...

Approved!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.