[Bug 454921] Review Request: pydotconf - python parser for dot.conf file

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pydotconf - python parser for dot.conf file


https://bugzilla.redhat.com/show_bug.cgi?id=454921





------- Additional Comments From goyal.hemant at gmail.com  2008-07-18 04:57 EST -------
Hi Mamoru,

Thanks for the review.

Package Updated.

SPEC URL :
http://www.nsitonline.in/hemant/stuff/python-dotconf/rpm/python-dotconf.spec
 
SRPM URL:
http://www.nsitonline.in/hemant/stuff/python-dotconf/rpm/python-dotconf-0.2-5.fc7.src.rpm


(In reply to comment #7)
> BTW
> 
> * Your latest package does not build on dist-f9-updates-candidate:
>   http://koji.fedoraproject.org/koji/taskinfo?taskID=722566
>   egg info is created on F-9/devel (I forgot for F-8)

It just did not strike me to scratch build on koji myself.

dist-f9
http://koji.fedoraproject.org/koji/taskinfo?taskID=723978 

dist-f10
http://koji.fedoraproject.org/koji/taskinfo?taskID=723983

dist-f8
http://koji.fedoraproject.org/koji/taskinfo?taskID=723982

dist-olpc3
http://koji.fedoraproject.org/koji/taskinfo?taskID=723985

> * Currently all branches are >= F-8 and %if 0%{?fedora} >= 8 is of no sense
>   (unless you are thinking of OLPC branch)

Yes I will be requesting an OLPC branch. However I have fixed it as follows 

%if 1%{?olpc}
BuildRequires: python-setuptools-devel
%else
BuildRequires: python-setuptools
%endif   

> * Currently no issue (as they are same), however would you clarify 
>   this package is GPLv3 or GPLv3+?

Thanks for checking this up. The license should have been GPLv3+. I have fixed
this now, however it will not be reflected in the SRPM built on koji scratch
build. I have made the requisite fix in the SPEC that that I have uploaded.

Thanks

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.