[Bug 454175] Review Request: gfs-nicefore-fonts - GFS Nicefore majuscule Greek font
bugzilla at redhat.com
bugzilla at redhat.com
Fri Jul 18 21:35:50 UTC 2008
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: gfs-nicefore-fonts - GFS Nicefore majuscule Greek font
https://bugzilla.redhat.com/show_bug.cgi?id=454175
------- Additional Comments From sundaram at redhat.com 2008-07-18 17:35 EST -------
OK | MUST: rpmlint is clean
OK | MUST: The package must be named according to the Package…
Shouldn't the font directory name be consistent? Under /usr/share/docs it is
gfs-nicecore-fonts and it is just called gfs-nicefore under /usr/share/fonts. I
suppose that is a matter of taste since font packages don't seem to follow any
particular convention here.
OK | MUST: The spec file name must match the base package…
OK | MUST: The package must meet the Packaging Guidelines…
OK | MUST: The package must be licensed with a Fedora approved…
OK | MUST: The License field in the package spec file must…
OK | MUST: Packaged detached license and specified in %doc
OK | MUST: The spec file for the package MUST be legible.
OK | MUST: The package must successfully compile and build…
OK | MUST: successfully compile, build
OK | MUST: All build dependencies must be listed…
OK | MUST: A package must own all directories that it creates
OK | MUST: A package must not contain any duplicate files
OK | MUST: Permissions on files must be set properly.
OK | MUST: Each package must have a %clean section
OK | MUST: Each package must consistently use macros
OK | MUST: The package must contain code, or permissible
OK | MUST: Packages must not own files or directories already
OK | MUST: At the beginning of %install, each package MUST…
OK | MUST: All filenames in rpm packages must be valid UTF-8.
OK | SHOULD: If the source package does not include license
OK | SHOULD: The description and summary section … translations…
OK | SHOULD: The package builds in mock
OK | SHOULD: The package builds on all supported architectures
OK | SHOULD: The reviewer should test that the package…
OK | SHOULD: If scriptlets are used, those scriptlets must be sane…
APPROVED
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
More information about the Fedora-package-review
mailing list