[Bug 453503] Review Request:zenon - Automated theorem prover for first-order classical logic

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request:zenon - Automated theorem prover for first-order classical logic


https://bugzilla.redhat.com/show_bug.cgi?id=453503





------- Additional Comments From dwheeler at dwheeler.com  2008-07-19 00:57 EST -------
Okay, new version of the package, which takes into account everything above. 
Would someone re-review them?  They are here:
 http://www.dwheeler.com/zenon.spec
 http://www.dwheeler.com/zenon-0.5.0-2.fc9.src.rpm

rpmlint reports 0 errors and 0 warnings on the .spec, SRPM, and the built
i386 binary for fedora 9.  It builds for all architectures for both
dist-f9 and dist-f10.

It actually builds for dist-f8 too, for all but ppc64.
I modified my .spec file to account for this, but I believe there's
an error in the build system, so it tries to build on ppc64 anyway
(the dist-f8 seems to think that it's fedora 9 instead, e.g., %fedora == 9).
I've already posted a bug report on what I think is an infrastructure issue:
 https://fedorahosted.org/fedora-infrastructure/ticket/711
Since building for f8 isn't a requirement, I propose reviewing this
for Fedora 9 and rawhide.  If there's a build infrastructure bug, hopefully
it will get fixed. If the problem is a bug in my specfile, then I
can release that SRPM separately instead.

Alan Dunn:
>Only one real recommendation I see at the moment, which is relatively minor: I
>would move tptp-COM003+2.p out of %doc - it's not really a documentation file,
>it's a data (non-binary) file that probably just belongs in %{_datadir}.

I've moved it into an "examples" subdirectory of its %doc directory;
there are no Fedora rules about this, so I used the
Debian guidelines as I proposed (above).  I think it's a good idea
to follow guidelines from other distros if a given distro doesn't care..
makes things easier for everyone (and if the guideline gets copied, we're
ahead of the game).

Creating the examples/ subdirectory turns out to be
trickier than I expected, because the "%doc" macro auto-erases
anything in document subdirectories, so I also documented how to
do this in general here:
 http://fedoraproject.org/wiki/PackageMaintainers/PackagingTricks
as recommended by Patrice Dumas.




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.