[Bug 456034] gnome-disk-utility - GNOME Disk Utility

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: gnome-disk-utility - GNOME Disk Utility


https://bugzilla.redhat.com/show_bug.cgi?id=456034





------- Additional Comments From davidz at redhat.com  2008-07-21 13:43 EST -------
(In reply to comment #6)
> [mclasen at golem ~]$ rpmlint gnome-disk-utility-*
> gnome-disk-utility.i386: W: no-documentation
> gnome-disk-utility-libs.i386: E: zero-length
> /usr/share/doc/gnome-disk-utility-0.1/HACKING

Fine. It's now one byte. Stupid tools.

> gnome-disk-utility-ui-devel.i386: W: no-documentation
> gnome-disk-utility-ui-libs.i386: W: no-documentation
> gnome-disk-utility-ui-libs.i386: E: postun-without-ldconfig
> /usr/lib/libgdu-gtk.so.0.0.0
> gnome-disk-utility-ui-libs.i386: E: non-empty-%postun /sbin/ldconfig

Excuse me? There's already 

 %post ui-libs -p /sbin/ldconfig
 %postun ui-libs -p /sbin/ldconfig

> 6 packages and 0 specfiles checked; 3 errors, 3 warnings.
>
> the no-docs can be ignored, the errors should be fixed.

(In reply to comment #7)
>   - source tag should be fixed up according to 
>     https://fedoraproject.org/wiki/Packaging/SourceURL

Fixed.

>   - the description should be more than a repetition of the summary. 
>     Ideally 1-2 complete sentences.

I've added some more, uh, stuff.

> BuildRequires: missing PolicyKit-gnome-devel, libsexy-devel, intltool

Fixed.

> locale handling:
>   - you should use find-lang --with-gnome %{name}, then it also picks
>     up the translated docs and adds proper %locale tags for them

As I said, there are zero translations right now. So that's why it's commented
out right now. If included it fails. Maybe it's an upstream problem. I don't know.

>   - /usr/share/omf/palimpsest/ needs to be owned. See above for how to
>     fix that with find-lang

Please elaborate, ideally in patch(1) form.

>   - /usr/include/gnome-disk-utility/ must be owned 

Done.

Uploaded new SPEC and SRPM at same location. Thanks for reviewing this.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.