[Bug 453083] Review Request: Samba4 - Samba4 CIFS and AD server and client

bugzilla at redhat.com bugzilla at redhat.com
Thu Jul 24 18:17:44 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Samba4 - Samba4 CIFS and AD server and client


https://bugzilla.redhat.com/show_bug.cgi?id=453083





------- Additional Comments From rdieter at math.unl.edu  2008-07-24 14:17 EST -------
1.  Should drop Epoch: 0

2.  drop
BR: ldconfig

3.  drop extraneous, hard-coded library deps
Requires: libtdb >= 0:%{tdb_version}
Requires: libtalloc >= 0:%{talloc_version}
should already be satisified by fedora's default versions (verified F9+)

4.  the -common deps
Requires(post): /sbin/chkconfig, /sbin/service, coreutils
Requires(preun): /sbin/chkconfig, /sbin/service
are misplaced.  these need to be in main pkg.  (and what's coreutils used for?)

5.  SHOULD use a recommended buildroot (cosmetic only).

Going to try some builds...

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the Fedora-package-review mailing list