[Bug 452395] Review Request: lxlauncher - Open source replacement for Asus Launcher of the EeePC

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: lxlauncher - Open source replacement for Asus Launcher of the EeePC


https://bugzilla.redhat.com/show_bug.cgi?id=452395


redhat at linuxnetz.de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From redhat at linuxnetz.de  2008-07-24 17:43 EST -------
Okay, let's do the official review: I checked all my points which are mostly 
equivalent to that ones already mentioned, so I'll not re-post my list. From 
my side I've no complaints at all.

> NOK | MUST: Packages containing GUI applications must include…

I agree with the requestor that no *.desktop is required, doesn't make sense
here. Maybe the hint for the autostart can be put into a README-FEDORA or a 
similar file, but per default enabled when maybe some/not all desktops/window 
managers are supporting it, is not ideal.

> NOK  | MUST: Packages must not own files or directories already

I can't see any issue here, the result in the built RPM package looks fine.


APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.