[Bug 455989] Review Request: xfce-mcs-plugins-extra - Extra plugins for the Xfce mcs manager

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xfce-mcs-plugins-extra - Extra plugins for the Xfce mcs manager


https://bugzilla.redhat.com/show_bug.cgi?id=455989





------- Additional Comments From fedora at christoph-wickert.de  2008-07-26 21:04 EST -------
(In reply to comment #1)
> 
> NOK  | MUST: The License field in the package spec file must…
> 
> License tag is incorrect. It is GPLv2 and not GPLv2+. Check the copyright
> headers under src directory. They are explicitly licensed under GPL v2 only. 

I thought I had looked that up but you are correct. Fixed.

> Install instructions mention that FSF is giving permission to copy, modify and
> redistribute. This is incorrect. Only the copyright holders are doing so. That
> bit needs to be fixed upstream. Please notify them. 

Will do.

> You might want to pass  --with-gnu-ld  in configure to speed up the process

Done.

> Please send a patch upstream to remove the hardcoded path you are working around
> in your spec file. 

Any idea how to do this best? I'm not really familiar with autotools, so I don't
want to add a ./configure. Debian/Ubuntu are also patching the file.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.