[Bug 429435] Review Request: gnubversion - Gnome interface to Subversion

bugzilla at redhat.com bugzilla at redhat.com
Mon Jul 28 15:16:12 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gnubversion - Gnome interface to Subversion


https://bugzilla.redhat.com/show_bug.cgi?id=429435





------- Additional Comments From lkundrak at v3.sk  2008-07-28 11:16 EST -------
Thanks for the package, Xavier.

Three things, all of them fairly trivial (and optional -- you may want to choose
to address them before commiting), so they won't block the approval. I'll
approve this once this builds in mock for me and inc case no more issues arise.

1.) Vendor tag

desktop-file-install                                    \
        --vendor ""                                     \


You probably want to set Vendor to "fedora" as per [1] (given this is a new
package it won't break the updates). 

[1] http://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files

2.) Encoding key

#Fix .desktop file
echo "Encoding=UTF-8" >>
$RPM_BUILD_ROOT%{_datadir}/applications/gvn-checkout.desktop

Actually the comment here is misleading. The Encoding key is in fact deprecated
[2]. This seems useless -- older desktop-file-utils implementations just issue a
warning here, not breaking the build (unless I am mistaken...).

[2]
http://standards.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html

3.) A typo in changelog

* Sun Jul 27 2008 Xavier Lamien <lxtnow[at]gmail.com - 0.5-3

You may want a ">" character after your e-mail address.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the Fedora-package-review mailing list