[Bug 444745] Review Request: perl-Tk-TableMatrix - Perl module for creating and manipulating tables

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Tk-TableMatrix - Perl module for creating and manipulating tables


https://bugzilla.redhat.com/show_bug.cgi?id=444745


xavier at bachelot.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |xavier at bachelot.org
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review?




------- Additional Comments From xavier at bachelot.org  2008-07-28 16:52 EST -------
+ source files match upstream : 6b7653d129bf1a8327054a88b58d6364
+ package meets naming and versioning guidelines.
+ specfile is properly named, is cleanly written and uses macros consistently.
+ dist tag is present.
+ build root is correct.
+ license field matches the actual license.
+ license is open source-compatible. License text is included.
+ latest version is being packaged.
+ BuildRequires are proper.
+ compiler flags are appropriate.
+ %clean is present.
+ package builds in mock.
+ package installs properly.

- rpmlint is silent :
perl-Tk-TableMatrix.i386: W: devel-file-in-non-devel-package
/usr/lib/perl5/vendor_perl/5.10.0/i386-linux-thread-multi/Tk/pTk/mm.h
perl-Tk-TableMatrix.i386: W: devel-file-in-non-devel-package
/usr/lib/perl5/vendor_perl/5.10.0/i386-linux-thread-multi/Tk/pTk/tkTable.h
perl-Tk-TableMatrix.i386: W: devel-file-in-non-devel-package
/usr/lib/perl5/vendor_perl/5.10.0/i386-linux-thread-multi/Tk/pTk/tkTableversion.h
perl-Tk-TableMatrix.i386: W: devel-file-in-non-devel-package
/usr/lib/perl5/vendor_perl/5.10.0/i386-linux-thread-multi/Tk/pTk/version.h

These ones are ok.

perl-Tk-TableMatrix.i386: E: wrong-script-end-of-line-encoding
/usr/share/doc/perl-Tk-TableMatrix-1.23/demos/edit_styles.pl
perl-Tk-TableMatrix.i386: W: spurious-executable-perm
/usr/share/doc/perl-Tk-TableMatrix-1.23/demos/basic
perl-Tk-TableMatrix.i386: W: spurious-executable-perm
/usr/share/doc/perl-Tk-TableMatrix-1.23/demos/buttons
perl-Tk-TableMatrix.i386: W: spurious-executable-perm
/usr/share/doc/perl-Tk-TableMatrix-1.23/demos/command
perl-Tk-TableMatrix.i386: W: spurious-executable-perm
/usr/share/doc/perl-Tk-TableMatrix-1.23/demos/debug
perl-Tk-TableMatrix.i386: W: spurious-executable-perm
/usr/share/doc/perl-Tk-TableMatrix-1.23/demos/dynarows
perl-Tk-TableMatrix.i386: W: spurious-executable-perm
/usr/share/doc/perl-Tk-TableMatrix-1.23/demos/edit_styles.pl
perl-Tk-TableMatrix.i386: W: spurious-executable-perm
/usr/share/doc/perl-Tk-TableMatrix-1.23/demos/maxsize
perl-Tk-TableMatrix.i386: W: spurious-executable-perm
/usr/share/doc/perl-Tk-TableMatrix-1.23/demos/spreadsheet
perl-Tk-TableMatrix.i386: W: spurious-executable-perm
/usr/share/doc/perl-Tk-TableMatrix-1.23/demos/SpreadsheetHideRows
perl-Tk-TableMatrix.i386: W: spurious-executable-perm
/usr/share/doc/perl-Tk-TableMatrix-1.23/demos/TableMatrixSpreadsheetTest
perl-Tk-TableMatrix.i386: W: spurious-executable-perm
/usr/share/doc/perl-Tk-TableMatrix-1.23/demos/TableMatrixTest

Please fix these ones.

+ final provides and requires are sane:
Provides:
 TableMatrix.so
 perl(Tk::TableMatrix) = 1.23
 perl(Tk::TableMatrix::Spreadsheet) = 1.23
 perl(Tk::TableMatrix::SpreadsheetHideRows) = 1.23

Requires:
 libX11.so.6
 libc.so.6
 libc.so.6(GLIBC_2.0)
 libc.so.6(GLIBC_2.1.3)
 libc.so.6(GLIBC_2.3)
 libc.so.6(GLIBC_2.3.4)
 libc.so.6(GLIBC_2.4)
 libm.so.6
 libnsl.so.1
 perl(AutoLoader)
 perl(Carp)
 perl(Tk)
 perl(Tk::Derived)
 perl(Tk::Submethods)
 perl(Tk::TableMatrix)
 perl(Tk::TableMatrix::Spreadsheet)
 perl(base)
 perl(strict)
 perl(vars)
 rtld(GNU_HASH)

+ %check is present and all tests pass
check is disabled by default (needs a display) and a compile switch is provided. 
+ owns the directories it creates.

+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets present.
+ code, not content.
+ documentation is small, so no -docs subpackage is necessary.
+ %docs are not necessary for the proper functioning of the package.


Please fix the rpmlint issues. Also, please reference the perl-Tk bug (RHBZ#456019).
Once this is done, I'll approve the package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.