[Bug 457059] Review Request: txt2tags - A document converter

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: txt2tags - A document converter


https://bugzilla.redhat.com/show_bug.cgi?id=457059





------- Additional Comments From kevin at tummy.com  2008-07-31 02:01 EST -------
OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
See below - License
See below - License field in spec matches
OK - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
e4d4553651b5be0711263378ca133c43  txt2tags-2.5.tgz
e4d4553651b5be0711263378ca133c43  txt2tags-2.5.tgz.rpm
See below - BuildRequires correct
OK - Spec handles locales/find_lang
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package has correct buildroot
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.
OK - Package has rm -rf RPM_BUILD_ROOT at top of %install

OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
See below - No rpmlint output.
OK - final provides and requires are sane.

SHOULD Items:

See below - Should build in mock.
OK - Should build on all supported archs
OK - Should function as described.
OK - Should have sane scriptlets.
OK - Should have dist tag
OK - Should package latest version

Issues:

1. The License tag here isn't right.
Take a look at the script at the top and the
http://fedoraproject.org/wiki/Licensing link in the wiki?

2. You seem to be missing a BuildRequires. It doesn't build here in mock.
I get:
/var/tmp/rpm-tmp.eTPqEv: line 41: msgfmt: command not found
fixing that I get:

3. rpmlint says:

txt2tags.noarch: E: wrong-script-interpreter
/usr/share/doc/txt2tags-2.5/samples/sample.mgp "/usr/X11R6/bin/mgp"

Is this even still used/shipped with xorg?

txt2tags.noarch: W: file-not-in-%lang /usr/share/man/zh/man1/txt2tags.1.gz

Is this not a translated man page? Perhaps it should be removed if not?

txt2tags.noarch: W: file-not-utf8 /usr/share/doc/txt2tags-2.5/extras/gvim-menu.vim
txt2tags.noarch: W: file-not-utf8 /usr/share/doc/txt2tags-2.5/extras/pagemaker.vim
txt2tags.noarch: W: file-not-utf8
/usr/share/doc/txt2tags-2.5/extras/txt2tags-mode.el
txt2tags.noarch: W: file-not-utf8 /usr/share/doc/txt2tags-2.5/extras/txt2tags.vim
txt2tags.noarch: W: file-not-utf8 /usr/share/doc/txt2tags-2.5/samples/sample.pm6
txt2tags.noarch: W: file-not-utf8 /usr/share/man/ca/man1/txt2tags.1.gz
txt2tags.noarch: W: file-not-utf8 /usr/share/man/es/man1/txt2tags.1.gz
txt2tags.noarch: W: file-not-utf8 /usr/share/man/fr/man1/txt2tags.1.gz
txt2tags.noarch: W: file-not-utf8 /usr/share/man/it/man1/txt2tags.1.gz
txt2tags.noarch: W: file-not-utf8 /usr/share/man/pt/man1/txt2tags.1.gz

These can probibly be ignored.
If they are dos format, you could convert them...

txt2tags.noarch: W: hidden-file-or-dir
/usr/share/doc/txt2tags-2.5/extras/._css-reference.txt
txt2tags.noarch: W: hidden-file-or-dir /usr/share/doc/txt2tags-2.5/extras/._ctags
txt2tags.noarch: W: hidden-file-or-dir /usr/share/doc/txt2tags-2.5/extras/._gensite
txt2tags.noarch: W: hidden-file-or-dir
/usr/share/doc/txt2tags-2.5/extras/._gvim-menu.vim
txt2tags.noarch: W: hidden-file-or-dir /usr/share/doc/txt2tags-2.5/extras/._nanorc
txt2tags.noarch: W: hidden-file-or-dir /usr/share/doc/txt2tags-2.5/extras/._README
txt2tags.noarch: W: hidden-file-or-dir
/usr/share/doc/txt2tags-2.5/extras/._txt2tags.php
txt2tags.noarch: W: hidden-file-or-dir
/usr/share/doc/txt2tags-2.5/extras/._txt2tagsrc
txt2tags.noarch: W: hidden-file-or-dir
/usr/share/doc/txt2tags-2.5/extras/._txt2tags.vim
txt2tags.noarch: W: hidden-file-or-dir
/usr/share/doc/txt2tags-2.5/samples/img/._t2tpowered-black.png
txt2tags.noarch: W: hidden-file-or-dir
/usr/share/doc/txt2tags-2.5/samples/._sample.t2t

Should be probibly ignored.

txt2tags.noarch: W: invalid-license GPL
txt2tags.src: W: invalid-license GPL

Will be fixed after license is fixed.

txt2tags.noarch: W: spurious-executable-perm
/usr/share/doc/txt2tags-2.5/extras/._gensite

Should be mode 644?

txt2tags.noarch: W: summary-ended-with-dot Summary: Converts text files to HTML,
XHTML, sgml, LaTeX, man...
txt2tags.src: W: summary-ended-with-dot Summary: Converts text files to HTML,
XHTML, sgml, LaTeX, man...

Might remove the ... and make it end in "and other formats" or something?

txt2tags.src:38: W: setup-not-quiet

Add -q to setup?

txt2tags.src: W: mixed-use-of-spaces-and-tabs (spaces: line 21, tab: line 1)

Can be ignored.

txt2tags.src: W: no-%build-section

You should have a build section, even if it's empty.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.