[Bug 441415] Review Request: wastesedge - Official game package for Adonthell

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: wastesedge - Official game package for Adonthell


https://bugzilla.redhat.com/show_bug.cgi?id=441415





------- Additional Comments From bochecha at no-log.org  2008-06-01 09:37 EST -------
About the icons location, I looked for it so I could have discuss this upstream,
and I found this in the Freedektop Icon Theme Spec
(http://standards.freedesktop.org/icon-theme-spec/latest/ar01s03.html):
> Icons and themes are looked for in a set of directories. By default, apps
> should look in $HOME/.icons (for backwards compatibility), in
> $XDG_DATA_DIRS/icons and in /usr/share/pixmaps (in that order).

Are you sure it has been deprecated ? Do you have another link explaining it so
I can sell this point upstream for future release ?

Another question, you said:
>  mv wastesedge_16x16.xpm /usr/share/icons/hicolor/16x16/apps/wastesedge.xpm
>  mv wastesedge_32x32.xpm /usr/share/icons/hicolor/32x32/apps/wastesedge.xpm

So I assume I should do that in a %post section, is that the preferred method
over simply patching the Makefile so that it installs in the right place ?

I corrected the "install -p" point, but you didn't make this remark in my other
submission. Is there a reason why I should do this in this package and not in
the other ? Or should I correct it in adonthell too ?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.