[Bug 449367] Review Request: tuxcmd - File manager with 2 panels side by side using GTK2
bugzilla at redhat.com
bugzilla at redhat.com
Mon Jun 2 15:52:13 UTC 2008
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: tuxcmd - File manager with 2 panels side by side using GTK2
https://bugzilla.redhat.com/show_bug.cgi?id=449367
dan at danny.cz changed:
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|nobody at fedoraproject.org |dan at danny.cz
Status|NEW |ASSIGNED
Flag| |fedora-review+
------- Additional Comments From dan at danny.cz 2008-06-02 11:52 EST -------
Format review:
OK source files match upstream:
4eb4cb6b033b68bfc86dc21fabdead8255118683 tuxcmd-0.6.36.tar.bz2
OK package meets naming and versioning guidelines.
OK specfile is properly named, is cleanly written and uses macros consistently.
OK dist tag is present.
OK build root is correct.
OK license field matches the actual license.
OK license is open source-compatible (GPLv2+). License text included in package.
OK latest version is being packaged.
OK BuildRequires are proper.
OK compiler flags are appropriate.
OK %clean is present.
OK package builds in mock (Rawhide/x86_64).
OK debuginfo package looks complete.
OK rpmlint is silent (W: executable-stack is an issue of fpc).
OK final provides and requires look sane.
N/A %check is present and all tests pass.
OK no shared libraries are added to the regular linker search paths.
OK owns the directories it creates.
OK doesn't own any directories it shouldn't.
OK no duplicates in %files.
OK file permissions are appropriate.
OK no scriptlets present.
OK code, not content.
OK documentation is small, so no -docs subpackage is necessary.
OK %docs are not necessary for the proper functioning of the package.
OK no headers.
OK no pkgconfig files.
OK no libtool .la droppings.
OK is a GUI app, desktop file is installed
This package is APPROVED.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
More information about the Fedora-package-review
mailing list