[Bug 445224] Review Request: stapitrace - user space instruction trace

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: stapitrace - user space instruction trace


https://bugzilla.redhat.com/show_bug.cgi?id=445224





------- Additional Comments From jwboyer at gmail.com  2008-06-02 21:06 EST -------
(In reply to comment #4)
> When you run the Systemtap translator, stap, it builds a kernel module, compiles
> it and runs it.  The usr_itrace.h is needed to compile the generated kernel
module.

Ah, yes.  Ok, makes sense.

> The package has not been developed for x86, although part usr_itrace.stp tapset
> was developed and tested somewhat on x86.  I'm just not sure if there pieces
> missing for x86 due to lack of development/testing on x86.

Hm.  Ok.  We'll come back to that in a bit.

More questions:

This looks like a subset of the dpiperf.dynamic package.  It seems to contain a
newer (?) version of the dpiperf.dynamic tarball that has simply been rebranded
to stapitrace-<version>.tar.gz in the SPEC file.  Is this a CVS snapshot of the
dpiperf tarball?

I ask because if it is, you should probably follow the snapshot guidelines[1]
instead of creating a tarball that can't actually be downloaded from the project
site.  One of the review criteria is that the package has verifiable source:

"- MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this package, please see the  Source URL
Guidelines for how to deal with this."


[1] https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Snapshot_packages

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.