[Bug 224458] Review Request: libsilc (dependency of gaim)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libsilc (dependency of gaim)


https://bugzilla.redhat.com/show_bug.cgi?id=224458





------- Additional Comments From stu at nosnilmot.com  2008-06-06 10:11 EST -------
(In reply to comment #4)
>   libsilc.x86_64: W: unused-direct-shlib-dependency 
>    /usr/lib64/libsilcclient-1.1.so.2.0.1 /lib64/libdl.so.2
> Not a huge deal, you might be able to fix this with the libtool tweak from
>
http://fedoraproject.org/wiki/PackageMaintainers/CommonRpmlintIssues#unused-direct-shlib-dependency
> if it bothers you.

Fixed in CVS (don't link libsilcclient to libdl)

> Then there are 249 of these:
>   libsilc.x86_64: W: undefined-non-weak-symbol 
>    /usr/lib64/libsilcclient-1.1.so.2.0.1 silc_hash_ptr
>   libsilc.x86_64: W: undefined-non-weak-symbol 
>    /usr/lib64/libsilcclient-1.1.so.2.0.1 silc_packet_set_keys
> It seems that libsilcclient doesn't actually link against libsilc, which would
> seem to be a bug to me.  Am I missing something?

Fixed in CVS, no you are missing nothing, that was a bug.

> The way dependencies are filtered is a bit fragile because it ignores any
> rpmbuild customizations involving the dependency generator.  I don't think it's
> a significant issue, but something akin to what many Perl modules which
> generates the filter on the fly might work better.  There's some discussion at 
> http://fedoraproject.org/wiki/Packaging/Perl#Filtering_Requires:_and_Provides

I changed the filtering to use a dynamically generated script similar to the
example.

> In any case, could you add a comment to the spec with a note on why you need to
> filter the dependencies?

It was mentioned in the %changelog, but I've copied that comment to the body of
the spec file too. The filtering is to fix bug #245323.

> It might be nice to clarify the meaning of SILC in %description.   Currently you
> either have to install the package and read the docs or search the network to
> figure out just what this package is supposed to do.

I've updated the description in CVS.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.