[Bug 450484] Review Request: telepathy-sofiasip - SIP connection manager for Telepathy

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: telepathy-sofiasip - SIP connection manager for Telepathy


https://bugzilla.redhat.com/show_bug.cgi?id=450484





------- Additional Comments From mcepl at redhat.com  2008-06-10 10:53 EST -------
OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistent macro usage.
OK - Has dist tag
OK - Meets Packaging Guidelines.
OK - License (LGPLv2+)
OK - License field in spec matches
OK - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
[matej at viklef redhat]$ md5sum SOURCES/telepathy-sofiasip-0.5.8.tar.gz 
023dceb1d48f34b7a9d5614cfda25907  SOURCES/telepathy-sofiasip-0.5.8.tar.gz
[matej at viklef redhat]$ md5sum ~/telepathy-sofiasip-0.5.8.tar.gz 
023dceb1d48f34b7a9d5614cfda25907  /home/matej/telepathy-sofiasip-0.5.8.tar.gz
[matej at viklef redhat]$ 
See below - BuildRequires correct (build in koji)
Not Sure - Package has %defattr and permissions on files is good.
%{_includedir}/%{name}-0.6/
do we have to have the number written there -- could not it be at least macro
somewhere in the top of the file? Or it won't change?

OK - Package has a correct %clean section.
OK - Package has correct buildroot
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.
OK - Package has rm -rf RPM_BUILD_ROOT at top of %install

OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
OK - Builds in mock (koji)
OK - Builds on all supported archs

OK - final provides and requires are sane

Rpmlint is not silent!!!
[matej at viklef redhat]$ rpmlint -i RPMS/i386/telepathy-sofiasip-0.5.8-1.fc9.i386.rpm 
telepathy-sofiasip.i386: W: devel-file-in-non-devel-package
/usr/include/telepathy-sofiasip-0.6/tpsip/event-target.h
A development file (usually source code) is located in a non-devel
package. If you want to include source code in your package, be sure to
create a development package.

telepathy-sofiasip.i386: W: devel-file-in-non-devel-package
/usr/include/telepathy-sofiasip-0.6/tpsip/sofia-decls.h
A development file (usually source code) is located in a non-devel
package. If you want to include source code in your package, be sure to
create a development package.

[matej at viklef redhat]$ 

Well I know it is intentional -- but I really think making -devel package is not
that big deal, and I am quite sure there will be more devel files coming (they
always come). Are you sure about this?

and (cosmetic)

[matej at viklef redhat]$ rpmlint -i SRPMS/telepathy-sofiasip-0.5.8-1.fc9.src.rpm
telepathy-sofiasip.src: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab:
line 18)
The specfile mixes use of spaces and tabs for indentation, which is a
cosmetic annoyance.  Use either spaces or tabs for indentation, not both.

[matej at viklef redhat]$ 

Just did :set et | retab | write 
in vim and attaching new .spec file

Conclusion:

I won't reject the review on the missing -devel package, but please consider
once again.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.