[Bug 252084] Review Request: jgraph - JGraph Diagram Component

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: jgraph - JGraph Diagram Component


https://bugzilla.redhat.com/show_bug.cgi?id=252084


balbir at linux.vnet.ibm.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |balbir at linux.vnet.ibm.com




------- Additional Comments From balbir at linux.vnet.ibm.com  2008-06-11 05:10 EST -------
Hi,

I just reviewed the package and found that the request was submitted in August
2007. Is this package still interesting? My review comments below (anyway).

Please run rpmlint on the source package. You'll find

1. The license is not correct
2. The group selected in not standard

Please remove things you don't need like
#%patch0 -b .sav

%{_docdir}/%{name}-%{version}/LICENSE Should use %doc

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.