[Bug 450850] Review Request: move - Move file(s) to ~/.trash directory

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: move - Move file(s) to ~/.trash directory


https://bugzilla.redhat.com/show_bug.cgi?id=450850





------- Additional Comments From rc040203 at freenet.de  2008-06-11 15:28 EST -------
Some remarks:

1. I do not consider this application to be useful, because it aims at
implementing "yet another backing-up mv" replacement, using the "n-th"
non-standardized mechanism.

2. Naming an application "move" is a bad choice, because it's such a general
name that it's likely colliding with many other applications/scripts users may
have installed.

Provided this, I am not interested in formally reviewing this packages (This
shouldn't preventr others from doing so.).


Some technical remarks:

* The package doesn't acknowledge CFLAGS.

The cause is this bug in Makefile:
--- Makefile.am~	2008-06-11 21:18:07.000000000 +0200
+++ Makefile.am	2008-06-11 21:18:07.000000000 +0200
@@ -11,7 +11,7 @@
 ## 6. automake -ac --foreign
 ##
 
-CFLAGS = -D_GNU_SOURCE
+AM_CPPFLAGS = -D_GNU_SOURCE
 
 bin_PROGRAMS = move
 move_SOURCES = move.c movedb.c move.h movedb.ham:

* The spec file uses /sbin/install-info
=> Missing: Requires(pre) etc.



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.