[Bug 450975] Review Request: libcanberra - Portable Sound Event Library

bugzilla at redhat.com bugzilla at redhat.com
Thu Jun 12 15:36:48 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libcanberra - Portable Sound Event Library


https://bugzilla.redhat.com/show_bug.cgi?id=450975





------- Additional Comments From lpoetter at redhat.com  2008-06-12 11:36 EST -------
(In reply to comment #3)

> packaging guidelines: see above for things rpmlint found. beyond that, the 
>   devel package needs to require pkg-config because it contains pc files 
>   and gtk-doc because it contains stuff in /usr/share/gtk-doc/help

Fixed.

> license: ok
> license field: ok
> license file: must be included

Fixed. 

> pc files: must add Requires: pkgconfig to -devel

Fixed.

> shared libs: see above, libcanberra-foo.so should be moved out of /usr/lib

See my earlier comments about this.

I uploaded an updated spec/srpm, but didn't bump the revision.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the Fedora-package-review mailing list