[Bug 450775] Review Request: perl-Panotools-Script - Panorama Tools scripting

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Panotools-Script - Panorama Tools scripting


https://bugzilla.redhat.com/show_bug.cgi?id=450775





------- Additional Comments From bruno at postle.net  2008-06-12 17:09 EST -------
(In reply to comment #1)

> The Source0 URL doesn't seem to be correct;
http://www.cpan.org/modules/by-module/Panotools doesn't seem to exist.

Fixed, www.cpan.org doesn't host all CPAN modules, but cpanspec thinks it does.

> I'm not sure I can understand what this package does given the %description
you have.

I've changed it to something more appropriate both in the SPEC file and upstream
SVN (this module has changed purpose somewhat since it was first created):

"Library and utilities for manipulating project files created by the hugin photo
stitching software."

> Why do you have a runtime dependency on desktop-file-utils?

%post/%postun both run update-desktop-database, but I see from the
ScriptletSnippets page that I don't need to put it in the SPEC, fixed.

Updated files:
http://fedorapeople.org/~bpostle/reviews/perl-Panotools-Script/perl-Panotools-Script.spec
http://fedorapeople.org/~bpostle/reviews/perl-Panotools-Script/perl-Panotools-Script-0.14-2.fc9.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.