[Bug 451012] Review Request: pspp - program for statistical analysis of sampled data

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pspp - program for statistical analysis of sampled data


https://bugzilla.redhat.com/show_bug.cgi?id=451012


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From tibbs at math.uh.edu  2008-06-14 13:09 EST -------
For some reason this one didn't build for me.

configure: error: The following required prerequisites are not installed.
You must install them before PSPP can be built:
        libglade 2.0 v2.6.0 or later (or use --without-gui)
This is confusing to me as it sure looks like it's been installed, and of course
koji works.  However, the failure is repeatable.

This also doesn't look like the version that was built in koji; you linked to
-2.0.tofail.fc9 but koji built -4.fc9.  I downloded -4 and it builds fine.

Everything I found is fixed:
- Summary is good.
- Test suite is run (the skipped test requires a postgres server)
   All 158 tests passed
   (1 tests were not run)
- /etc/pspp is owned now.
- I don't know why I X'ed the scriptlets; they seem fine to me now.
- .la files are gone.
- desktop file is installed now and looks OK.
- unversioned .so files are gone.

However, because you have both:
  %config(noreplace) %{_sysconfdir}/pspp/*
and
  %{_sysconfdir}/pspp
you get several errors like these:
  warning: File listed twice: /etc/pspp/psfonts
  warning: File listed twice: /etc/pspp/psfonts/Courier-Bold.afm
at the end of the build.  You should replace that second line with
  %dir %{_sysconfdir}/pspp
and things should be OK.

You can make that fix when you check in.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.