[Bug 436677] Review Request: xxdiff

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xxdiff


https://bugzilla.redhat.com/show_bug.cgi?id=436677





------- Additional Comments From thomas.moschny at gmx.de  2008-06-18 03:42 EST -------
[x],[~] = ok, [!] = problem, [-] = not applicable

[x] package meets naming guidelines
[x] specfile is encoded in ascii or utf-8
[x] specfile matches base package name
[~] specfile uses macros consistently
    could use %{name} in some more places
[~] specfile is written cleanly
    could have some more explaining comments, e.g.
    - upstream status for patch?
    - removal of shebang lines
[x] specfile is written in AE
[x] changelog is present and has correct format
[x] license matches actual license
[x] license is open source-compatible
[x] license text is included in package
[~] source tag has correct url
    ok, has been discussed in the review
[~] source files match upstream
    ok, has been discussed
[x] latest version is packaged
[x] summary is concise
[x] dist tag is present
[x] buildroot is correct
[x] buildroot is prepped
[x] %clean is present
[x] proper build requirements
[x] proper requirements
[x] uses %{?_smp_mflags}
[x] uses %{optflags}
[x] doesn't use %makeinstall
[x] package builds at least on one architecture
    tested on: fedora-9-x86_64
[x] packages installs and runs at least on one architecture
    tested on: fedora-9-x86_64
[x] rpmlint is quiet
[x] final provides/requires look sane
[-] ldconfig called in %post and %postun if required
[x] code, not content
[x] file permissions are appropriate
[x] debuginfo package looks usable
[-] config files marked as %config(noreplace)
[x] owns all the directories it creates
[-] static libraries in -devel subpackage
[-] header files in -devel subpackage
[-] development .so files in -devel subpackage
[-] pkgconfig files in -devel subpackage, requires pkgconfig
[-] no .la files
[-] doesn't need a -docs subpackage
[x] relevant docs are included
[x] doc files are not needed at runtime
[~] provides a .desktop file, build-requires desktop-file-utils
    ok, has been discussed in the review
[-] uses %find_lang, build-requires gettext

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.