[Bug 444428] Review Request: ocaml-cmigrep - Search OCaml compiled interface (cmi) files

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ocaml-cmigrep - Search OCaml compiled interface (cmi) files


https://bugzilla.redhat.com/show_bug.cgi?id=444428


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |tibbs at math.uh.edu
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review+




------- Additional Comments From tibbs at math.uh.edu  2008-06-18 18:59 EST -------
I guess selinux will probably become annoyed by the executable stack, but as
long as the package isn't broken in general I don't see a need to wait until
everything rebuilds.  That hasn't happened so far, so I won't wait any longer.

I don't think it's particularly pretty to have to include the entire compiler
source, but I've had to do the same thing and I don't see an alternative other
than waiting for the one you mention in the spec to happen.

Besides, there really isn't much to this package, just a lot of build time for
one file.

You should probably include the COPYING file as %doc as well.  That's really the
only nit I see to pick.

* source files match upstream:
  e420d4ad1ebf062bb4d02028fadccd11a6c5cf7ddde159ebb607f2fefa4ea989  
   cmigrep-1.5.tar.bz2
  3755a32da1a7490d47fff7838c12c754d3fcfe69d7c9ff2358704259dc477c58  
   ocaml-3.10.2.tar.bz2
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* rpmlint has acceptable complaints.
* final provides and requires are sane:
   ocaml-cmigrep = 1.5-2.fc10
  =
   libpcre.so.0()(64bit)

* no shared libraries are added to the regular linker search paths.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.